MQTTReader: make client_name optional and ensure client_id is unique#577
Merged
davidpablocohn merged 1 commit intoJun 23, 2026
Conversation
This commit makes the `client_name` constructor param optional, allowing the underlying Paho MQTT library to generate a random ID as needed. If `client_name` is provided, it is appended with 6 random characters to help ensure uniqueness.
davidpablocohn
approved these changes
Jun 23, 2026
Collaborator
|
Ah - just realized we merged this into master. In general I like to stage by merging into dev first. I'll go ahead and cherry pick the change, then merge it into dev as well. |
davidpablocohn
added a commit
that referenced
this pull request
Jun 23, 2026
…577) (#579) This commit makes the `client_name` constructor param optional, allowing the underlying Paho MQTT library to generate a random ID as needed. If `client_name` is provided, it is appended with 6 random characters to help ensure uniqueness. Co-authored-by: Michael D Labriola <mdlabriola@oceanexplorationtrust.org>
Contributor
Author
Oops, that's my bad. I didn't even think about it when I wrote the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the
client_nameconstructor param optional, allowing the underlying Paho MQTT library to generate a random ID as needed. Ifclient_nameis provided, it is appended with 6 random characters to help ensure uniqueness.W/out this patch, if you accidentally supply the same
client_namefor multiple readers (say, via a template), each new connection causes the broker to disconnect all previous instances, and only the last instance receives messages.